Add Commissioning over Thread Meshcop for python controller#43029
Merged
andy31415 merged 6 commits intoFeb 13, 2026
Conversation
github-actions
Bot
added
tools
examples
scripts
setup payload
platform
linux
lib
inet
controller
app
github
workflows
tests
support
labels
pullapprove
Bot
added
review - pending
and removed
tools
examples
scripts
setup payload
platform
linux
lib
inet
controller
app
github
workflows
tests
support
labels
|
PR #43029: Size comparison from 485755f to 7d912f1 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/controller/ThreadMeshcopCommissionProxy.cpp:419
peerAddr.GetIPAddress().ToString(host)drops any interface scope information. If the Border Agent address is IPv6 link-local, petitioning without the%ifacezone will typically fail. Consider constructinghostincluding the interface frompeerAddr.GetInterface()(similar toPeerAddress::ToStringfor UDP/TCP), or otherwise preserving the original scoped string.
|
PR #43029: Size comparison from 485755f to 0d956b6 Full report (16 builds for cc13x4_26x4, cc32xx, nrfconnect, psoc6, qpg, realtek, stm32)
|
|
PR #43029: Size comparison from 485755f to e83433e Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43029: Size comparison from 485755f to 56e7252 Full report (10 builds for cc13x4_26x4, cc32xx, nrfconnect, realtek, stm32)
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/controller/ThreadMeshcopCommissionProxy.cpp:33
- This file uses
strerror(errno)but does not include<cstring>/<string.h>. Some toolchains will fail to compile due to missing declaration. Add the appropriate header forstrerror.
|
PR #43029: Size comparison from 485755f to b5aa96a Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43029: Size comparison from 429a4d7 to 49e1ebb Full report (3 builds for cc32xx, stm32)
|
|
PR #43029: Size comparison from 429a4d7 to 369466e Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
chshu
approved these changes
Feb 12, 2026
|
PR #43029: Size comparison from 429a4d7 to eab2384 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43029: Size comparison from 429a4d7 to 3ef3cb1 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Contributor
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
src/controller/ThreadMeshcopCommissionProxy.cpp:33
- This file now calls
strerror(errno)but only includes<errno.h>(it no longer includes<error.h>). Add the appropriate header (<cstring>/<string.h>) sostrerroris declared reliably across toolchains.
|
PR #43029: Size comparison from dad34d4 to fe165db Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43029: Size comparison from 07f6efb to 3ef3cb1 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is based on #42992 and adding the following changes:
Testing
Tested with python controller scripts using
--commissioning-method thread-meshcop