Skip to content

feat(FR-2451): add prometheus tab scaffolding to AdminServingPage#7082

Open
agatha197 wants to merge 1 commit intomainfrom
04-27-feat_fr-2451_add_auto_scaling_rule_tab_scaffolding_to_adminservingpage
Open

feat(FR-2451): add prometheus tab scaffolding to AdminServingPage#7082
agatha197 wants to merge 1 commit intomainfrom
04-27-feat_fr-2451_add_auto_scaling_rule_tab_scaffolding_to_adminservingpage

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Apr 27, 2026

Resolves #6357 (FR-2451)

Summary

This is Sub-task 1 of 5 in the FR-2451 stack delivering Prometheus Query Preset admin CRUD. It is the foundation PR — it adds the new tab entry but renders only a placeholder; subsequent PRs in the stack fill in the list, create modal, edit modal with live preview, and delete flow.

Changes

  • Add a new auto-scaling-rule tab to AdminServingPage's tabList, gated behind isSuperAdmin (mirrors the existing model-store gating pattern).
  • Render a placeholder AutoScalingRulePresetTab component (lazy-loaded, wrapped in BAIErrorBoundary + Suspense) that currently renders an active Skeleton.
  • Add the i18n key webui.menu.AutoScalingRule in resources/i18n/en.json. Other locales will be filled in by /i18n later.
  • Stage the dev plan and progress files under .specs/draft-auto-scaling-rule-management/ so the stack's planning context is checked in alongside the first PR.

Files changed

  • react/src/pages/AdminServingPage.tsx — add lazy import, tab list entry, lazy render branch
  • react/src/components/AutoScalingRulePresetTab.tsx (new) — placeholder component with 'use memo' directive
  • resources/i18n/en.json — new webui.menu.AutoScalingRule key
  • .specs/draft-auto-scaling-rule-management/dev-plan.md, .specs/draft-auto-scaling-rule-management/.context/progress.md — planning context for the FR-2451 stack

Verification

=== TypeScript ===
--- TypeScript: PASS ---

=== ALL PASS ===

bash scripts/verify.sh passes (Relay + Lint + Format + TypeScript).

Stack

This is the bottom of a 5-PR Graphite stack:

  1. (this PR) tab scaffolding
  2. preset list (read + filter + pagination)
  3. create preset modal
  4. edit preset modal + live "Current value" preview
  5. delete preset flow

Each subsequent PR is gated by the previous one and will reuse the placeholder component as the mount point for real functionality.

@github-actions github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels Apr 27, 2026
Copy link
Copy Markdown
Contributor Author

agatha197 commented Apr 27, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
9.04% (+0% 🔼)
1859/20570
🔴 Branches
8.19% (-0% 🔻)
1187/14489
🔴 Functions
5.33% (+0.02% 🔼)
297/5577
🔴 Lines
8.77% (+0% 🔼)
1750/19955
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / AutoScalingRulePresetTab.tsx
0% 100% 0% 0%

Test suite run success

865 tests passing in 40 suites.

Report generated by 🧪jest coverage report action from e0a386e

Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_add_auto_scaling_rule_tab_scaffolding_to_adminservingpage branch from 6d0065a to e92805e Compare April 28, 2026 07:14
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_add_auto_scaling_rule_tab_scaffolding_to_adminservingpage branch from e92805e to e0a386e Compare April 28, 2026 11:38
@agatha197 agatha197 changed the title feat(FR-2451): add Auto Scaling Rule tab scaffolding to AdminServingPage feat(FR-2451): add prometheus tab scaffolding to AdminServingPage Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding Prometheus Query Preset CRUD page (admin)

2 participants