feat(FR-2451): add prometheus tab scaffolding to AdminServingPage#7082
Open
feat(FR-2451): add prometheus tab scaffolding to AdminServingPage#7082
Conversation
Contributor
Author
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 9.04% (+0% 🔼) |
1859/20570 |
| 🔴 | Branches | 8.19% (-0% 🔻) |
1187/14489 |
| 🔴 | Functions | 5.33% (+0.02% 🔼) |
297/5577 |
| 🔴 | Lines | 8.77% (+0% 🔼) |
1750/19955 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / AutoScalingRulePresetTab.tsx |
0% | 100% | 0% | 0% |
Test suite run success
865 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from e0a386e
This was referenced Apr 27, 2026
669f2f9 to
6d0065a
Compare
This was referenced Apr 27, 2026
Open
6d0065a to
e92805e
Compare
e92805e to
e0a386e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #6357 (FR-2451)
Summary
This is Sub-task 1 of 5 in the FR-2451 stack delivering Prometheus Query Preset admin CRUD. It is the foundation PR — it adds the new tab entry but renders only a placeholder; subsequent PRs in the stack fill in the list, create modal, edit modal with live preview, and delete flow.
Changes
auto-scaling-ruletab toAdminServingPage'stabList, gated behindisSuperAdmin(mirrors the existingmodel-storegating pattern).AutoScalingRulePresetTabcomponent (lazy-loaded, wrapped inBAIErrorBoundary+Suspense) that currently renders an activeSkeleton.webui.menu.AutoScalingRuleinresources/i18n/en.json. Other locales will be filled in by/i18nlater..specs/draft-auto-scaling-rule-management/so the stack's planning context is checked in alongside the first PR.Files changed
react/src/pages/AdminServingPage.tsx— add lazy import, tab list entry, lazy render branchreact/src/components/AutoScalingRulePresetTab.tsx(new) — placeholder component with'use memo'directiveresources/i18n/en.json— newwebui.menu.AutoScalingRulekey.specs/draft-auto-scaling-rule-management/dev-plan.md,.specs/draft-auto-scaling-rule-management/.context/progress.md— planning context for the FR-2451 stackVerification
bash scripts/verify.shpasses (Relay + Lint + Format + TypeScript).Stack
This is the bottom of a 5-PR Graphite stack:
Each subsequent PR is gated by the previous one and will reuse the placeholder component as the mount point for real functionality.