Skip to content

feat(FR-2451): polish preset list — BAINameActionCell, copyable QueryTemplate, column settings, i18n#7095

Open
agatha197 wants to merge 4 commits into04-27-feat_fr-2451_add_prometheus_query_preset_edit_modal_with_live_previewfrom
04-27-feat_fr-2451_polish_preset_list_bainameactioncell_copyable_querytemplate_column_settings_i18n
Open

feat(FR-2451): polish preset list — BAINameActionCell, copyable QueryTemplate, column settings, i18n#7095
agatha197 wants to merge 4 commits into04-27-feat_fr-2451_add_prometheus_query_preset_edit_modal_with_live_previewfrom
04-27-feat_fr-2451_polish_preset_list_bainameactioncell_copyable_querytemplate_column_settings_i18n

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Apr 27, 2026

Resolves #6357 (FR-2451)

Stacked on top of #7094.

Changes

PrometheusQueryPresetList — UX polish

  • BAINameActionCell: Edit and Delete actions moved into the name column via BAINameActionCell (showActions="always"). The separate general.Control column is removed.
  • Query Template copyable: Typography.Text copyable added so users can copy the full PromQL template with one click.
  • BAITableSettings: Column visibility gear icon added via internal columnOverrides state. createdAt and updatedAt are defaultHidden: true; name is required: true.

BAITable

  • Default value of resizable changed from falsetrue so all BAITable instances support column resizing without opt-in.
  • Generic constraint tightened: RecordType extends object = anyRecordType extends AnyObject = AnyObject to align with the interface constraint.

i18n

  • 26 new keys (prometheusQueryPreset.* namespace + webui.menu.AutoScalingRule) translated into all 20 target languages (de, el, es, fi, fr, id, it, ja, ko, mn, ms, pl, pt-BR, pt, ru, th, tr, vi, zh-CN, zh-TW).

Verification

=== Relay === PASS
=== Lint === PASS
=== Format === PASS
=== TypeScript === PASS
=== ALL PASS ===

Copy link
Copy Markdown
Contributor Author

agatha197 commented Apr 27, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
8.96% (-0% 🔻)
1859/20753
🔴 Branches
8.11% (-0.01% 🔻)
1187/14638
🔴 Functions
5.28% (+0.01% 🔼)
297/5620
🔴 Lines
8.69% (-0% 🔻)
1750/20132
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / PrometheusPresetTab.tsx
0% 0% 0% 0%

Test suite run success

865 tests passing in 40 suites.

Report generated by 🧪jest coverage report action from 99735c7

@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_polish_preset_list_bainameactioncell_copyable_querytemplate_column_settings_i18n branch from 1e39e76 to e7c2b8c Compare April 28, 2026 00:43
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_polish_preset_list_bainameactioncell_copyable_querytemplate_column_settings_i18n branch from e7c2b8c to 55d3a53 Compare April 28, 2026 03:20
@github-actions github-actions Bot added the area:lib Library and SDK related issue. label Apr 28, 2026
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_add_prometheus_query_preset_edit_modal_with_live_preview branch from d5b7705 to 747c4a3 Compare April 28, 2026 06:06
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_polish_preset_list_bainameactioncell_copyable_querytemplate_column_settings_i18n branch from 55d3a53 to 6e94a8c Compare April 28, 2026 06:06
Comment thread react/src/components/PrometheusQueryPresetNodes.tsx Outdated
Comment thread react/src/components/PrometheusQueryPresetNodes.tsx Outdated
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_add_prometheus_query_preset_edit_modal_with_live_preview branch from 747c4a3 to f93b2b9 Compare April 28, 2026 07:13
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_polish_preset_list_bainameactioncell_copyable_querytemplate_column_settings_i18n branch from 6e94a8c to ab6a4c0 Compare April 28, 2026 07:13
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_add_prometheus_query_preset_edit_modal_with_live_preview branch from f93b2b9 to 9049625 Compare April 28, 2026 07:14
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_polish_preset_list_bainameactioncell_copyable_querytemplate_column_settings_i18n branch from ab6a4c0 to 93ab994 Compare April 28, 2026 07:14
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_add_prometheus_query_preset_edit_modal_with_live_preview branch from 9049625 to 16f01ea Compare April 28, 2026 07:51
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_polish_preset_list_bainameactioncell_copyable_querytemplate_column_settings_i18n branch 2 times, most recently from 6fc42ee to 549d61f Compare April 28, 2026 07:59
@agatha197 agatha197 requested a review from nowgnuesLee April 28, 2026 08:00
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_polish_preset_list_bainameactioncell_copyable_querytemplate_column_settings_i18n branch from 549d61f to b41245b Compare April 28, 2026 11:38
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_add_prometheus_query_preset_edit_modal_with_live_preview branch 2 times, most recently from 1ab0fc6 to 76ca308 Compare April 28, 2026 12:21
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_polish_preset_list_bainameactioncell_copyable_querytemplate_column_settings_i18n branch from b41245b to 62ffd10 Compare April 28, 2026 12:21
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_add_prometheus_query_preset_edit_modal_with_live_preview branch from 76ca308 to 4a72130 Compare April 28, 2026 12:26
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_polish_preset_list_bainameactioncell_copyable_querytemplate_column_settings_i18n branch from 62ffd10 to 21c5894 Compare April 28, 2026 12:26
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_polish_preset_list_bainameactioncell_copyable_querytemplate_column_settings_i18n branch from 21c5894 to 99735c7 Compare April 28, 2026 12:37
@agatha197 agatha197 force-pushed the 04-27-feat_fr-2451_add_prometheus_query_preset_edit_modal_with_live_preview branch from 4a72130 to 1e12616 Compare April 28, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants