feat(FR-2451): add Prometheus Query Preset delete confirmation#7086
Open
agatha197 wants to merge 1 commit into04-27-feat_fr-2451_add_prometheus_query_preset_create_modalfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 27, 2026
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.98% (-0.01% 🔻) |
1859/20701 |
| 🔴 | Branches | 8.14% (-0.01% 🔻) |
1187/14583 |
| 🔴 | Functions | 5.29% (+0.01% 🔼) |
297/5617 |
| 🔴 | Lines | 8.71% (-0% 🔻) |
1750/20082 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / PrometheusQueryPresetNodes.tsx |
0% | 0% | 0% | 0% |
Test suite run success
865 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from f6aee58
be5f281 to
8973048
Compare
130e2af to
98a23f6
Compare
This was referenced Apr 27, 2026
Open
nowgnuesLee
requested changes
Apr 28, 2026
98a23f6 to
f34e805
Compare
274f8d7 to
a0e765e
Compare
a0e765e to
ad7bcd7
Compare
nowgnuesLee
requested changes
Apr 28, 2026
ad7bcd7 to
d27efb4
Compare
f34e805 to
57c25be
Compare
nowgnuesLee
requested changes
Apr 28, 2026
57c25be to
8f6b3c7
Compare
d27efb4 to
6a520df
Compare
8f6b3c7 to
66852a9
Compare
6a520df to
44475aa
Compare
44475aa to
f6aee58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #6357 (FR-2451)
Stacked on top of #7085.
Summary
Adds a destructive Delete action to each row of the Prometheus Query Preset table, gated by a typed-confirmation modal as required by
.claude/rules/destructive-confirmation.md.general.Control) on the right side ofPrometheusQueryPresetListwith adangerDeleteOutlinedicon button. The list now accepts anonDeletePreset(row)callback prop.AutoScalingRulePresetTab), mirroring the editor-modal mount pattern from Sub-task 3. Clicking Delete sets a{ id, name }target; the orchestrator renders a singleBAIConfirmModalWithInputwhose OK button only enables once the user types the preset's exactname.AutoScalingRulePresetTabDeleteMutationcallingadminDeletePrometheusQueryPreset(id: ID!). On success:message.successtoast +updateFetchKey()to refetch the list. On error: per-error toast and modal closes (matchesResourcePresetList.tsxconvention)..claude/rules/destructive-confirmation.md,Popconfirm/ single-clickmodal.confirmare not used — onlyBAIConfirmModalWithInput.i18n keys added (under
prometheusQueryPreset.*)PermanentlyDeletePreset— modal title with{{ name }}interpolationDeleteWarning— warning content shown in the modal AlertSuccessfullyDeleted— success toastExisting keys reused:
button.Delete,general.Control,dialog.TypeNameToConfirmDeletion.Verification