feat(FR-2451): implement Prometheus Query Preset list table#7084
Open
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 9.02% (-0.01% 🔻) |
1859/20621 |
| 🔴 | Branches | 8.17% (-0.02% 🔻) |
1187/14523 |
| 🔴 | Functions | 5.31% (+0.01% 🔼) |
297/5592 |
| 🔴 | Lines | 8.75% (-0.01% 🔻) |
1750/20005 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / PrometheusQueryPresetList.tsx |
0% | 0% | 0% | 0% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / AutoScalingRulePresetTab.tsx |
0% | 0% (-100% 🔻) |
0% | 0% |
Test suite run success
865 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from 0eebe06
This was referenced Apr 27, 2026
669f2f9 to
6d0065a
Compare
2c15caf to
ebd1d50
Compare
This was referenced Apr 27, 2026
Open
nowgnuesLee
requested changes
Apr 28, 2026
ebd1d50 to
31cd4e2
Compare
6d0065a to
e92805e
Compare
31cd4e2 to
c074b00
Compare
e92805e to
e0a386e
Compare
c074b00 to
0eebe06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #6357 (FR-2451)
Stacked on top of #7082.
Summary
Sub-task 2 of FR-2451. Replaces the placeholder body in the new "Auto Scaling Rule" admin tab with a real, paginated, filterable Prometheus Query Preset list (read-only). This is the second PR in a 5-PR stack delivering Prometheus Query Preset admin CRUD.
What ships now
AutoScalingRulePresetTabis now a query orchestrator that runsprometheusQueryPresets(filter, limit, offset)viauseLazyLoadQuery, withparseAsJsonURL state forfilteranduseBAIPaginationOptionStateOnSearchParamLegacyfor offset/limit.PrometheusQueryPresetListcomponent renders theBAITableand consumes a per-rowPrometheusQueryPresetListFragment(@relay(plural: true)onQueryDefinition). Columns:Name,Metric Name,Query Template(truncated with tooltip),Time Window,Created At,Updated At.BAIGraphQLPropertyFilterfor thenamefield — the only filterQueryDefinitionFilterexposes today (verified againstdata/schema.graphql). Filter is flattened back to a flat object before sending so it matches the schema's flatQueryDefinitionFiltershape (mirrorsAdminModelCardListPage'sflattenGraphQLFilterpattern).BAIFetchKeyButton, transition-driven loading viauseDeferredValue.description,rank,categoryId,options.{filterLabels,groupLabels}, andcategoryare spread now even though the table doesn't render all of them yet, so Sub-tasks 3/4 (Create / Edit modal) can reuse the same fragment without refactoring this component.i18n
Added
prometheusQueryPreset.*namespace inresources/i18n/en.jsonwith only the keys this PR actually uses:Name,MetricName,QueryTemplate,TimeWindow,CreatedAt,UpdatedAt,AddPreset. Subsequent sub-tasks will add the rest (Description,Category,Rank,FilterLabels,GroupLabels, modal copy, delete copy).Out of scope (future PRs in the stack)
adminCreatePrometheusQueryPresetmutationBAIConfirmModalWithInput+adminDeletePrometheusQueryPreset)Verification