feat(FR-2451): add Prometheus Query Preset edit modal with live preview#7094
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 81.87% | 429/524 |
| 🟡 | Branches | 70.43% | 362/514 |
| 🟡 | Functions | 76.86% | 93/121 |
| 🟢 | Lines | 83.19% | 391/470 |
Test suite run success
319 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from 1e12616
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.97% (-0.01% 🔻) |
1859/20733 |
| 🔴 | Branches | 8.12% (-0.02% 🔻) |
1187/14625 |
| 🔴 | Functions | 5.29% (+0.02% 🔼) |
297/5617 |
| 🔴 | Lines | 8.7% (-0.01% 🔻) |
1750/20114 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / PrometheusPresetPreview.tsx |
0% | 0% | 0% | 0% |
Test suite run success
865 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from 1e12616
8973048 to
274f8d7
Compare
d5b7705 to
747c4a3
Compare
747c4a3 to
f93b2b9
Compare
274f8d7 to
ad7bcd7
Compare
ad7bcd7 to
d27efb4
Compare
9049625 to
16f01ea
Compare
d27efb4 to
6a520df
Compare
1ab0fc6 to
76ca308
Compare
44475aa to
f6aee58
Compare
76ca308 to
4a72130
Compare
4a72130 to
1e12616
Compare

Resolves #6357 (FR-2451)
Summary
PrometheusPresetPreviewfromAutoScalingRuleEditorModal.tsxinto a new sharedPrometheusPresetPreview.tsxmodule. This is a pure move — zero behavior change inAutoScalingRuleEditorModal. The Relay query (PrometheusPresetPreviewResultQuery) now lives in the new file.PrometheusQueryPresetEditorModal: callsadminModifyPrometheusQueryPresetwith a diff-only input (only changed fields are sent; label arrays correctly distinguish "user cleared to[]" from "unchanged/omitted").<PrometheusPresetPreview presetGlobalId={preset.id} />. Preview is edit-only (no ID available in create mode).EditOutlined) added to the left of the Delete button in thePrometheusQueryPresetListaction column.AutoScalingRulePresetTabwireseditingPresetstate and passes the fragment ref into<PrometheusQueryPresetEditorModal presetFrgmt={editingPreset} />.prometheusQueryPreset.SuccessfullyUpdatedtoen.json.Verification